Skip to content

Conversation

@jriddle-linode
Copy link
Collaborator

@jriddle-linode jriddle-linode commented Oct 20, 2023

📝 Description

What does this PR do and why is this change necessary?

Change Firewalls to Cloud Firewall which is the correct term used in the API.
Remove Block Storage Migration from the table.
Rename Blocks to Block

Resolves #532

@jriddle-linode jriddle-linode requested a review from a team as a code owner October 20, 2023 18:18
@jriddle-linode jriddle-linode requested review from yec-akamai and ykim-akamai and removed request for a team October 20, 2023 18:18
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran linode region-table and it works well!

Do you have any idea of why the ci is failling? It seems some package is not able to be installed correctly.

@ykim-akamai
Copy link
Contributor

FW column have check marks when running linode-cli region-table locally

@lgarber-akamai
Copy link
Contributor

lgarber-akamai commented Oct 23, 2023

Ran linode region-table and it works well!

Do you have any idea of why the ci is failling? It seems some package is not able to be installed correctly.

@yec-akamai I looked into this a bit and it seems to be related to the removal of pkg_resources in Python 3.12. Fortunately it looks like we already have a ticket to investigate resolving it (TPT-2406) 🙂

@jriddle-linode jriddle-linode merged commit fa2e11a into linode:dev Oct 25, 2023
@jriddle-linode jriddle-linode deleted the fix/region-table branch October 25, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Onjuiste CloudFirewall kolom in region-tabel.

4 participants