Fix boto3 missing error message in obj extension
#544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
lgarber-akamai and
ykim-akamai
and removed request for
a team
zliang-akamai
changed the title
call function handle boto3 missing and print err msgcall function print boto3 error message in obj extension
ykim-akamai
approved these changes
Nov 3, 2023
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
GJ!, works well locally
jcallahan-akamai
approved these changes
Nov 4, 2023
Contributor
jcallahan-akamai
left a comment
jcallahan-akamai
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! It works as expected locally.
zliang-akamai
changed the title
call function print boto3 error message in obj extensionboto3 missing error message in obj extension
vshanthe
pushed a commit
to vshanthe/linode-cli
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We imported boto3 in
objects.pywhich skips the boto3 check logic__init__.py. Addedtry ... except ...block to ignore the exception and let thecallfunction in__init__.pyto print the error message.✔️ How to Test
make installpython3 -m pip uninstall boto3 -ylinode obj lsGHA run passed: https://github.com/linode/linode-cli/actions/runs/6750190271