test: Separate applying calico rules to different job; add job to apply cfw after integration tests are executed; update test_invalid_file test case #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remaining instances
ykim-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
ykim-akamai
changed the title
ykim-akamai
changed the title
lgarber-akamai
approved these changes
Oct 29, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks like the new jobs are working as expected on my fork, excellent work!
https://github.com/lgarber-akamai/linode-cli/actions/runs/11580706851/job/32241074302
zliang-akamai
approved these changes
Oct 30, 2024
zliang-akamai
added
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Improvements to e2e CI:
test_pathtomodulefor simplicitye.g.
Test cases
test_invalid_fileandtest_ssh_instance_provisioningare updated accordingly to reflect recent stderr change✔️ How to Test
make TEST_CASE="test_invalid_file" testintmake TEST_CASE="test_ssh_instance_provisioning" testintTested in forked - https://github.com/ykim-1/linode-cli/actions/runs/11506669904
note: failed cases are not related to this PR but verified the security steps after integration job is finished
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.