Skip to content

Conversation

@rammanoj
Copy link
Contributor

@rammanoj rammanoj commented Oct 21, 2025

📝 Description

  • Add firewall_id to nodepool

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

  • Run pip install . to install the PR in the local environment.
  • Create an LKE-E Cluster and use the below config to create a nodePool with a label.
  • Create a NodePool with an existing firewall using the following code and ensure created nodes are attached to provided firewall
# creating for a new pool
client = LinodeClient("<api-token>", "https://api.linode.com/v4beta")
cluster = LKECluster(client, <existing-enterprise-cluster-id>)
node_pool = cluster.node_pool_create("g6-dedicated-2", 3, firewall_id=<firewall-id>)
print(node_pool.firewall_id)
  • Update the firewall of the nodepool to a new firewall and ensure it is changed.
# update the node pool and ensure that firewall_id is updated
client = LinodeClient("d48ca47c674a9560c0ef6b81fcda7c459341e960e2154ead8b56e28476851fec", "https://api.linode.com/v4beta")
pool = LKENodePool(client, 763514, 526430)
pool.firewall_id = 3374023
pool.save()
print(pool.firewall_id)

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@rammanoj rammanoj marked this pull request as ready for review October 24, 2025 15:41
@rammanoj rammanoj requested a review from a team as a code owner October 24, 2025 15:41
@rammanoj rammanoj requested review from jriddle-linode and zliang-akamai and removed request for a team October 24, 2025 15:41
@lgarber-akamai lgarber-akamai self-requested a review October 27, 2025 18:10
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Everything's working well on my end.

FYI for other reviewers, you can run the integration tests using:

make test-int TEST_COMMAND=models/lke

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally for me, looks good!

@lgarber-akamai lgarber-akamai merged commit 06b09b8 into linode:dev Oct 27, 2025
12 checks passed
@zliang-akamai zliang-akamai added the new-feature for new features in the changelog. label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants