Skip to content

Conversation

@zliang-akamai
Copy link
Member

📝 Description

This is no longer a valid attribute of the structs.

✔️ How to Test

Automated Testing

make ARGS="-run TestInstance_Disk" fixtures

Manual Testing

package main

import (
	"context"
	"os"

	"github.com/linode/linodego"
)

func main() {
	ctx := context.Background()

	client := linodego.NewClient(nil)
	client.SetToken(os.Getenv("LINODE_TOKEN"))

	linodeClient.CreateInstanceDisk(
		context.Background(),
		123456, // your Linode ID
		linodego.InstanceDiskCreateOptions{
			Label: "somedisk",
			Size: 500,
		},
	)
}

@zliang-akamai zliang-akamai requested a review from a team as a code owner March 1, 2024 18:47
@zliang-akamai zliang-akamai requested review from lgarber-akamai and yec-akamai and removed request for a team March 1, 2024 18:47
@zliang-akamai zliang-akamai force-pushed the zhiwei/drop-disk-read-only branch from 0c9fc4c to 797ce65 Compare March 1, 2024 18:47
@zliang-akamai zliang-akamai requested a review from yec-akamai March 2, 2024 03:57
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@zliang-akamai zliang-akamai merged commit 3de1f50 into linode:main Mar 4, 2024
@zliang-akamai zliang-akamai deleted the zhiwei/drop-disk-read-only branch March 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants