Added support for VPC DBaaS Integration #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
lgarber-akamai,
yec-akamai and
zliang-akamai
and removed request for
a team
|
|
||
| EngineConfig *PostgresDatabaseEngineConfig `json:"engine_config,omitempty"` | ||
| EngineConfig *PostgresDatabaseEngineConfig `json:"engine_config,omitempty"` | ||
| PrivateNetwork *DatabasePrivateNetwork `json:"private_network,omitempty"` |
Contributor
There was a problem hiding this comment.
Normally I'd be a concerned about whether this type of substruct would diverge per-database type in the future, but I don't think that's likely in this case.
Contributor
Author
There was a problem hiding this comment.
Yeah I thought separating it out into two separate structs, but I agree its not likely to diverge.
lgarber-akamai
added a commit
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for VPC/DBaaS Integration features and unit tests.
✔️ How to Test
The following test steps assume you have pulled down this PR locally.
Unit Testing
make test-unit