TPT-4224: Add OBJ global quota and usage#899
Merged
zliang-akamai merged 6 commits intomainfrom May 4, 2026
Merged
Conversation
zliang-akamai
requested review from
ezilber-akamai and
psnoch-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive support for Object Storage quotas in the Linode Go SDK, including both endpoint-specific quotas and new global/account-level quotas. The changes extend the existing quota system with new fields and introduce a parallel set of APIs for global quotas.
Changes:
- Added
QuotaTypeandHasUsagefields toObjectStorageQuotastruct to support new quota metadata - Introduced
ObjectStorageGlobalQuotaandObjectStorageGlobalQuotaUsagetypes with corresponding List/Get methods for account-level quotas - Updated integration tests to validate the new fields and created comprehensive tests for global quota operations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| object_storage_quota.go | Added QuotaType and HasUsage fields to ObjectStorageQuota; introduced ObjectStorageGlobalQuota and ObjectStorageGlobalQuotaUsage types with List/Get/GetUsage methods |
| test/integration/object_storage_quota_test.go | Updated tests to use flexible assertions for new fields instead of hard-coded expected values |
| test/integration/object_storage_global_quota_test.go | Added comprehensive tests for global quota List, Get, and Usage operations |
| test/integration/fixtures/TestObjectStorageQuotas_List.yaml | Updated fixture with new API response format including quota_type and has_usage fields |
| test/integration/fixtures/TestObjectStorageQuotas_Get.yaml | Updated fixture to include quota_type and has_usage fields |
| test/integration/fixtures/TestObjectStorageGlobalQuotas_List.yaml | New fixture for global quotas list endpoint |
| test/integration/fixtures/TestObjectStorageGlobalQuotas_Get.yaml | New fixture for global quota get endpoint |
| test/integration/fixtures/TestObjectStorageGlobalQuotaUsage_Get.yaml | New fixture for global quota usage endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
approved these changes
Feb 24, 2026
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tests passing locally. Nice work!
zliang-akamai
changed the title
zliang-akamai
changed the title
zliang-akamai
changed the title
ckulinsk
reviewed
Apr 29, 2026
ckulinsk
left a comment
ckulinsk
left a comment
There was a problem hiding this comment.
Tests passing locally, looks good to me.
ckulinsk
approved these changes
Apr 30, 2026
ckulinsk
left a comment
ckulinsk
left a comment
There was a problem hiding this comment.
Looks, good to me, and tests passed locally - approved.
zliang-akamai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Support updates about OBJ quotas
✔️ How to Test
make TEST_ARGS="-run TestObjectStorageQuotas_Get" fixturesmake TEST_ARGS="-run TestObjectStorageQuotas_List" fixtures