TPT-4113: Add support for Expand Create Linodes Options and Password-less Linodes#956
Merged
Conversation
* Implemented changes for SLADE and CLEO projects * Fixes * Add comments to mention AuthorizedUsers
…s and password less (#944) * Fixes * Creates test cases for linode password-less option * Apply code review suggestions * Replace sting to constant variables --------- Co-authored-by: ezilber-akamai <ezilber@akamai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Linode instance/disk option structs and accompanying tests to support additional create-time fields (kernel/boot size) and to cover “password-less” provisioning behavior (authorized keys/users instead of root password) via unit + integration fixtures.
Changes:
- Add
KernelandBootSizetoInstanceCreateOptions. - Clarify/create test coverage around the requirement to provide one of
root_pass,authorized_keys, orauthorized_userswhen creating from an image. - Strengthen unit tests by validating request bodies for instance create/rebuild and disk create, and add new integration tests + fixtures.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
instances.go |
Adds Kernel/BootSize to instance create options; reorganizes option fields and adds documentation notes. |
instance_disks.go |
Updates disk create options documentation/field grouping around auth fields for image-based disk creation. |
test/unit/instance_test.go |
Validates POST request bodies for instance create/rebuild and updates create options to include kernel/boot size. |
test/unit/instance_disks_test.go |
Validates POST request body for disk creation and ensures root password is included in the test request. |
test/integration/instances_test.go |
Adds integration coverage for missing auth fields on image create, plus a kernel/boot-size create flow followed by disk create + rebuild. |
test/integration/fixtures/TestInstance_TestExpectedErrorIfFieldsAuthorizedUsersAuthorizedKeysRootPassAreNotSet.yaml |
New cassette covering 400 error when image create omits root_pass/authorized_keys/authorized_users. |
test/integration/fixtures/TestInstance_TestCreateLinodeWithKernelAndBootSizeThenAddDiskAndRebuild.yaml |
New cassette covering create-with-kernel/boot-size, disk creation (incl. busy retries), rebuild, and teardown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mawilk90
reviewed
May 7, 2026
mawilk90
reviewed
May 7, 2026
lgarber-akamai
approved these changes
May 7, 2026
yec-akamai
approved these changes
May 7, 2026
mawilk90
approved these changes
May 7, 2026
zliang-akamai
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for SLADE + CLEO features.
✔️ How to Test
make test-unitmake test-int