Skip to content

TPT-4113: Add support for Expand Create Linodes Options and Password-less Linodes#956

Merged
ezilber-akamai merged 8 commits into
mainfrom
proj/slade-cleo
May 7, 2026
Merged

TPT-4113: Add support for Expand Create Linodes Options and Password-less Linodes#956
ezilber-akamai merged 8 commits into
mainfrom
proj/slade-cleo

Conversation

@ezilber-akamai
Copy link
Copy Markdown
Contributor

📝 Description

Added support for SLADE + CLEO features.

✔️ How to Test

make test-unit
make test-int

ezilber-akamai and others added 3 commits April 7, 2026 13:45
* Implemented changes for SLADE and CLEO projects

* Fixes

* Add comments to mention AuthorizedUsers
…s and password less (#944)

* Fixes

* Creates test cases for linode password-less option

* Apply code review suggestions

* Replace sting to constant variables

---------

Co-authored-by: ezilber-akamai <ezilber@akamai.com>
Copilot AI review requested due to automatic review settings May 6, 2026 20:04
@ezilber-akamai ezilber-akamai added the project for new projects in the changelog. label May 6, 2026
@ezilber-akamai ezilber-akamai requested review from a team as code owners May 6, 2026 20:04
@ezilber-akamai ezilber-akamai requested review from mawilk90 and zliang-akamai and removed request for a team May 6, 2026 20:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Linode instance/disk option structs and accompanying tests to support additional create-time fields (kernel/boot size) and to cover “password-less” provisioning behavior (authorized keys/users instead of root password) via unit + integration fixtures.

Changes:

  • Add Kernel and BootSize to InstanceCreateOptions.
  • Clarify/create test coverage around the requirement to provide one of root_pass, authorized_keys, or authorized_users when creating from an image.
  • Strengthen unit tests by validating request bodies for instance create/rebuild and disk create, and add new integration tests + fixtures.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
instances.go Adds Kernel/BootSize to instance create options; reorganizes option fields and adds documentation notes.
instance_disks.go Updates disk create options documentation/field grouping around auth fields for image-based disk creation.
test/unit/instance_test.go Validates POST request bodies for instance create/rebuild and updates create options to include kernel/boot size.
test/unit/instance_disks_test.go Validates POST request body for disk creation and ensures root password is included in the test request.
test/integration/instances_test.go Adds integration coverage for missing auth fields on image create, plus a kernel/boot-size create flow followed by disk create + rebuild.
test/integration/fixtures/TestInstance_TestExpectedErrorIfFieldsAuthorizedUsersAuthorizedKeysRootPassAreNotSet.yaml New cassette covering 400 error when image create omits root_pass/authorized_keys/authorized_users.
test/integration/fixtures/TestInstance_TestCreateLinodeWithKernelAndBootSizeThenAddDiskAndRebuild.yaml New cassette covering create-with-kernel/boot-size, disk creation (incl. busy retries), rebuild, and teardown.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread instances.go Outdated
@psnoch-akamai psnoch-akamai requested review from psnoch-akamai and removed request for psnoch-akamai May 7, 2026 07:40
Comment thread test/integration/instances_test.go Outdated
Comment thread test/integration/instances_test.go
@ezilber-akamai ezilber-akamai merged commit 93b5f84 into main May 7, 2026
11 checks passed
@zliang-akamai zliang-akamai deleted the proj/slade-cleo branch May 7, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project for new projects in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants