fix: initialize all org.slf4j classes at build time for GraalVM native image#120
Merged
fix: initialize all org.slf4j classes at build time for GraalVM native image#120
Conversation
…e image Logback's build-time initialization transitively triggers org.slf4j.MarkerFactory, which was not in the explicit build-time init list. Replace individual org.slf4j class entries with the whole org.slf4j package to prevent this and similar future issues.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--initialize-at-build-timeentries fororg.slf4j.LoggerFactoryandorg.slf4j.helpers.Reporterwith a singleorg.slf4jpackage-level entryorg.slf4j.MarkerFactorybuild-time initialization error in CLI native image build (run #22354123577)Root Cause
Logback's build-time initialization transitively triggers
org.slf4j.MarkerFactoryto initialize. SinceMarkerFactorywasn't explicitly listed in the build-time init args, GraalVM treated it as a run-time class that was incorrectly initialized at build time, failing the native image build.Test plan