Rename examples/ to app/ and cli/ for production app structure#42
Merged
Rename examples/ to app/ and cli/ for production app structure#42
Conversation
- examples/app -> app/shared, examples/androidApp -> app/android, examples/desktopApp -> app/desktop, examples/webApp -> app/web, examples/iosApp -> app/ios, examples/cli -> cli - Rename packages: com.linroid.kdown.examples -> com.linroid.kdown.app (cli uses com.linroid.kdown.cli) - Update Gradle module names, namespaces, applicationId, and iOS framework name (ExamplesApp -> KDownApp) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Test Results756 tests ±0 756 ✅ ±0 12s ⏱️ -1s Results for commit 8fa7037. ± Comparison against base commit ca1c9db. This pull request removes 84 and adds 84 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Required by Compose Multiplatform for ProMotion display support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit d8dd017.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/intoapp/(shared, android, desktop, web, ios) and top-levelcli/com.linroid.kdown.examplestocom.linroid.kdown.app/com.linroid.kdown.cliExamplesApp→KDownApp)Test plan
compileKotlinJvm,compileDebugKotlin,compileKotlinWasmJs):app:shared:jvmTest)KDownAppframework import🤖 Generated with Claude Code