block: replace wq users and add WQ_PERCPU to alloc_workqueue() users#184
Closed
blktests-ci[bot] wants to merge 3 commits intolinus-master_basefrom
Closed
block: replace wq users and add WQ_PERCPU to alloc_workqueue() users#184blktests-ci[bot] wants to merge 3 commits intolinus-master_basefrom
blktests-ci[bot] wants to merge 3 commits intolinus-master_basefrom
Conversation
Author
|
Upstream branch: c8bc81a |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
45f2b7a to
1d2502f
Compare
Author
|
Upstream branch: d1d10ce |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
268844c to
ce6ee34
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
1d2502f to
7254eb7
Compare
Author
|
Upstream branch: d1d10ce |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
ce6ee34 to
32bced4
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7254eb7 to
7fb5c4d
Compare
Author
|
Upstream branch: b236920 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
32bced4 to
dd7141a
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7fb5c4d to
8f78eb6
Compare
Author
|
Upstream branch: 76eeb9b |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
dd7141a to
37f1d61
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
8f78eb6 to
fc2da57
Compare
Author
|
Upstream branch: f777d11 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
37f1d61 to
6916f28
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
fc2da57 to
79c38cd
Compare
Author
|
Upstream branch: 7aac719 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
6916f28 to
1056794
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
79c38cd to
a17e495
Compare
Author
|
Upstream branch: 320475f |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
1056794 to
cbc880b
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
a17e495 to
4366bd4
Compare
Author
|
Upstream branch: 22f2037 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
cbc880b to
7432ce5
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
4366bd4 to
c5248c1
Compare
Author
|
Upstream branch: 46a51f4 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
7432ce5 to
554e787
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
c5248c1 to
13a6f93
Compare
Author
|
Upstream branch: 5aca796 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
554e787 to
1269f62
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
13a6f93 to
ba17659
Compare
Author
|
Upstream branch: 992d4e4 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
1269f62 to
e1320fd
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
ba17659 to
3f46741
Compare
Author
|
Upstream branch: 8b789f2 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
e1320fd to
3a28d36
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
3f46741 to
1c2ea74
Compare
Author
|
Upstream branch: 097a6c3 |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
3a28d36 to
e78da47
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
1c2ea74 to
2208c28
Compare
Author
|
Upstream branch: 07e27ad |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
e78da47 to
0ff0c0f
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
2208c28 to
73f860f
Compare
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. Adding system_dfl_wq to encourage its use when unbound work should be used. queue_work() / queue_delayed_work() / mod_delayed_work() will now use the new unbound wq: whether the user still use the old wq a warn will be printed along with a wq redirect to the new one. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. Adding system_dfl_wq to encourage its use when unbound work should be used. queue_work() / queue_delayed_work() / mod_delayed_work() will now use the new unbound wq: whether the user still use the old wq a warn will be printed along with a wq redirect to the new one. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they’re needed and reducing noise when CPUs are isolated. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they’re needed and reducing noise when CPUs are isolated. This patch adds a new WQ_PERCPU flag to explicitly request the use of the per-CPU behavior. Both flags coexist for one release cycle to allow callers to transition their calls. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. All existing users have been updated accordingly. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Author
|
Upstream branch: 07e27ad |
blktests-ci
Bot
force-pushed
the
series/999229=>linus-master
branch
from
0ff0c0f to
181599c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block: replace wq users and add WQ_PERCPU to alloc_workqueue() users
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=999229