Log when CTAP2 bio_enrollment responses return None fields#153
Conversation
|
Thanks @jkaiwar! I believe If this is more common, I would defer to @msirringhaus on the specifics on biometrics enrollment. |
|
I would agree that |
|
I would reserve |
337b018 to
733c9ef
Compare
|
Sounds good @AlfioEmanueleFresta @msirringhaus. I have changed the levels to warn. |
AlfioEmanueleFresta
left a comment
There was a problem hiding this comment.
Thank you @jkaiwar!
This PR adds
info!logs in the error paths for a couple ofBioEnrollmentimplementation methods, which previously returnedError::Ctap(CtapError::Other)silently under some CTAP requests to channels, where the response hadNonefields that were expected to beSome.Maintainers: Are these logs desirable in the context of #14 ? How appropriate are the messages and log-levels I have chosen?