fix(cable): preserve I/O error kind on the WebSocket data channel#218
Merged
Conversation
AlfioEmanueleFresta
force-pushed
the
feat/pxp-ble
branch
from
78214b6 to
1bca6b7
Compare
Map tungstenite::Error::Io to TransportError::IoError(kind), matching the L2capDataChannel variant strategy so the CableDataChannel trait is useful for differentiating failure modes regardless of transport. Treat Error::ConnectionClosed as a clean close in recv to match the existing handling of Message::Close. Protocol-level errors still map to ConnectionFailed.
AlfioEmanueleFresta
force-pushed
the
feat/pxp-ble-ws-error-kind
branch
from
fe83184 to
3a701bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tungstenite::Error::IotoTransportError::IoError(kind)inWebSocketDataChannel::{send, recv}, matchingL2capDataChannel's variant strategy so theCableDataChanneltrait abstraction lets callers differentiate failure modes regardless of transport.tungstenite::Error::ConnectionClosedas a clean close inrecv(returnsOk(None)), matching howMessage::Closeis already handled.Tls,Capacity,Protocol,Utf8,Url,Http,AlreadyClosed, etc.) still map toTransportError::ConnectionFailed.Stacked on top of #216.
Test plan
cargo build --workspace --all-featurescargo clippy --workspace --all-features --all-targets -- -D warningscargo test --workspace --all-features --lib(258 passed)cargo fmt --all -- --check