Merged
Conversation
Collaborator
|
Not everything under /usr/share/dbus-1/system-services uses /bin/false, why? |
Collaborator
Author
To be researched. It is very odd that both the DBus service and the Service which is being activated both have an Exec line. I would prefer if we don't exec anything on the DBus activatable and just leave that to the service. |
Collaborator
|
The first two commits are doing too many things at once. Can you split the renaming bits into a separate commit? maybe |
Collaborator
Author
Yeah, I was also hoping in separating into parts which I already know that work. |
This variable is generally unset.
See https://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-starting-services-systemd and https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Examples. install_symlink requires meson 0.61.0. See https://mesonbuild.com/Reference-manual_functions.html#install_symlink.
See https://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-starting-services-systemd and https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Examples. install_symlink requires meson 0.61.0. See https://mesonbuild.com/Reference-manual_functions.html#install_symlink.
As per `systemd.unit(5)` Want= is preferable over Requires=, since xdg-desktop-portal could appear latter and it would not be an issue. In principle it does not matter if we start serving the portal before xdg-desktop-portal so we don't declare After=.
Collaborator
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were before, but simply by running the binaries. This makes it so that they start the service instead. The /usr/bin/false comes from:
this needs testing.