client/tests: Fix spurious test keyring paths#426
Merged
bilelmoussaoui merged 1 commit intolinux-credentials:mainfrom Mar 14, 2026
Merged
client/tests: Fix spurious test keyring paths#426bilelmoussaoui merged 1 commit intolinux-credentials:mainfrom
bilelmoussaoui merged 1 commit intolinux-credentials:mainfrom
Conversation
file_unlocked_keyring.rs calculated the path for test keyring like '../../tests/test.keyring'. This usually goes outside the project root. For example ~/oo7 $ cargo test creates ~/tests/test.keyring. Depending on directory setup, tests pass unnoticed, fail with permission denied or worst case corrupt unrelated previously existing files. Fix it by using tempdir(), as other tests already do it.
bilelmoussaoui
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_unlocked_keyring.rscalculated the path for test keyring like"../../tests/test.keyring". This usually goes outside the project root. For examplecreates
~/tests/test.keyring. Depending on directory setup, tests pass unnoticed, fail with permission denied or worst case corrupt unrelated previously existing files.Fix it by using
tempdir(), as other tests already do it.