Skip to content

[pull] master from aria2:master #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
May 15, 2026
+12 −1
Merged

[pull] master from aria2:master #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44aa33d
gnutls: Perform ExtendedKeyUsage validation
tatsuhiro-t May 15, 2026
64365cf
Merge pull request #2356 from aria2/gnutls-perform-eku-validation
tatsuhiro-t May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/LibgnutlsTLSSession.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,16 @@ int GnuTLSSession::tlsConnect(const std::string& hostname, TLSVersion& version,
}
if (tlsContext_->getVerifyPeer()) {
// verify peer
gnutls_typed_vdata_st data[] = {
{
GNUTLS_DT_KEY_PURPOSE_OID,
reinterpret_cast<unsigned char*>(
const_cast<char*>(GNUTLS_KP_TLS_WWW_SERVER)),
},
};
unsigned int status;
rv_ = gnutls_certificate_verify_peers2(sslSession_, &status);
rv_ = gnutls_certificate_verify_peers(
sslSession_, data, sizeof(data) / sizeof(data[0]), &status);
if (rv_ != GNUTLS_E_SUCCESS) {
return TLS_ERR_ERROR;
}
Expand All @@ -278,6 +286,9 @@ int GnuTLSSession::tlsConnect(const std::string& hostname, TLSVersion& version,
if (status & GNUTLS_CERT_EXPIRED) {
handshakeErr += " `expired'";
}
if (status & GNUTLS_CERT_PURPOSE_MISMATCH) {
handshakeErr += " `unsuitable certificate purpose`";
}
// TODO Add GNUTLS_CERT_SIGNATURE_FAILURE here
if (!handshakeErr.empty()) {
return TLS_ERR_ERROR;
Expand Down
Loading