Stub support for fwrite, fremove, fclose_fd, fopen_with_env_fd#21
Stub support for fwrite, fremove, fclose_fd, fopen_with_env_fd#21z3ntu wants to merge 9 commits into
Conversation
This is good to print for completeness, and can be useful when extending fopen to not just allow read operations. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Make sure that the message is useful and doesn't just print a hex number like "1f050100". "Unexpected buffer count for method 31: 1f050100 (in: 5 vs 2, out: 1 vs 1)" is a much more descriptive and helpful error. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Add a config for hexagonrpc with the preferred indentation style, and some other settings. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
I think it's just the same function with a different data type for the file descriptor, where it's
I don't even see the use case for writing to any backing files and persistently storing them, beyond offloading the JSON config-to-registry conversions. |
|
Where do you suggest we store the files temporarily then? Just in RAM, in |
I'd say, |
|
Do you have an idea how to resolve the situation that we probably want to continue to have the read-only Open file read-only:
Open file read-write:
Delete file:
If we wanted to support deleting a file that's originally provided in |
NOTE: This package is using the tree from this PR: linux-msm/hexagonrpc#21 Without this PR (by @z3ntu), newer Snapdragon chips won't work (as there are missing calls) This package comes with the hexagonrpcd service which works alongside libssc Both this service and the data files in /usr/share/qcom are required for the Qualcomm SSC sensors to work. Signed-off-by: Gianni Spadoni <me@gio.blue>
NOTE: This package is using the tree from this PR: linux-msm/hexagonrpc#21 Without this PR (by @z3ntu), newer Snapdragon chips won't work (as there are missing calls) This package comes with the hexagonrpcd service which works alongside libssc Both this service and the data files in /usr/share/qcom are required for the Qualcomm SSC sensors to work. Signed-off-by: Gianni Spadoni <me@gio.blue>
NOTE: This package is using the tree from this PR: linux-msm/hexagonrpc#21 Without this PR (by @z3ntu), newer Snapdragon chips won't work (as there are missing calls) This package comes with the hexagonrpcd service which works alongside libssc Both this service and the data files in /usr/share/qcom are required for the Qualcomm SSC sensors to work. Signed-off-by: Gianni Spadoni <me@gio.blue>
NOTE: This package is using the tree from this PR: linux-msm/hexagonrpc#21 Without this PR (by @z3ntu), newer Snapdragon chips won't work (as there are missing calls) This package comes with the hexagonrpcd service which works alongside libssc Both this service and the data files in /usr/share/qcom are required for the Qualcomm SSC sensors to work. Signed-off-by: Gianni Spadoni <me@gio.blue>
NOTE: This package is using the tree from this PR: linux-msm/hexagonrpc#21 Without this PR (by @z3ntu), newer Snapdragon chips won't work (as there are missing calls) This package comes with the hexagonrpcd service which works alongside libssc Both this service and the data files in /usr/share/qcom are required for the Qualcomm SSC sensors to work. Signed-off-by: Gianni Spadoni <me@gio.blue>
|
@lumag ping, since we were talking about this :) |
|
@z3ntu Okay. My rough guess: |
Initial feedback welcome,
the first commits can be applied in my opinion(see #22), not sure how we want to do the later commits.For
fopen_with_env_fd(or thefopen_fdfunction that I haven't implemented) I'm honestly not sure what thefdshould be or would be used for. It's the same data type as the "fd" for the other functions (e.g. fread) but seems for a different purpose? Not quite sure, but the ADSP is happy enough getting random stub data there.Also in general, not sure how to handle a mutable version of hexagonrpc, I know rmtfs has a similar issue but there it keeps a copy of the original file in-memory or something, but it's obviously more difficult for a whole file system. Maybe copy the read-only version from
/usr/share/qcomto/var/lib/hexagonrpc/and modify it there only, depending on what's requested?Log on Milos (Fairphone (Gen. 6)), initializing the sensors far enough to work with iio-sensor-proxy:
output.txt
Fixes #19