Skip to content

Add discovery_ctrl_set() to Python bindings#114

Merged
hreinecke merged 1 commit intolinux-nvme:masterfrom
martin-belanger:add-tp8013-to-python
Nov 17, 2021
Merged

Add discovery_ctrl_set() to Python bindings#114
hreinecke merged 1 commit intolinux-nvme:masterfrom
martin-belanger:add-tp8013-to-python

Conversation

@martin-belanger
Copy link
Copy Markdown
Contributor

Add discovery_ctrl_set() to Python bindings

Following Hannes' recent TP8013 changes, we need
to add this method to the Python bindings.

Signed-off-by: Martin Belanger martin.belanger@dell.com

Following Hannes' recent TP8013 changes, we need
to add this method to the Python bindings.

Signed-off-by: Martin Belanger <martin.belanger@dell.com>
@hreinecke
Copy link
Copy Markdown
Collaborator

Can you check PR #112? I think that should already do the trick...

@martin-belanger
Copy link
Copy Markdown
Contributor Author

PR #112 does not add nvme_ctrl_set_discovery_ctrl() to libnvme.map, which is needed by discovery_ctrl_set() in the Python bindings.

@hreinecke
Copy link
Copy Markdown
Collaborator

Ah, indeed, you are right. I've forgot about that.

@hreinecke hreinecke merged commit 7e43586 into linux-nvme:master Nov 17, 2021
@martin-belanger martin-belanger deleted the add-tp8013-to-python branch December 1, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants