Add libjson version check on configure to fix build error#131
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Dec 9, 2021
Merged
Add libjson version check on configure to fix build error#131igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
json_util_get_last_err, json_object_to_fd are supported from json-c-0.13-20171207 if json-c version is lower than 0.13, build without it Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Collaborator
|
Makes sense, for the meson build we set the min version to 0.13 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json_util_get_last_err, json_object_to_fd are supported from json-c-0.13-20171207
if json-c version is lower than 0.13, build without it
Signed-off-by: Steven Seungcheol Lee sc108.lee@samsung.com
if not checking the version, make will be failed with below for lower version of json-c
/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld: ../src//libnvme.a(json.ol): in function
json_read_config': /root/Desktop/repo/libnvme_upstream/src/nvme/json.c:164: undefined reference tojson_util_get_last_err'/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld: ../src//libnvme.a(json.ol): in function
json_update_config': /root/Desktop/repo/libnvme_upstream/src/nvme/json.c:290: undefined reference tojson_object_to_fd'/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld: /root/Desktop/repo/libnvme_upstream/src/nvme/json.c:295: undefined reference to
json_util_get_last_err' /opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld: /root/Desktop/repo/libnvme_upstream/src/nvme/json.c:295: undefined reference tojson_util_get_last_err'collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:29: test] Error 1