util: modify flbas rsvd bits to be used#164
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jan 19, 2022
Merged
Conversation
This was referenced Jan 7, 2022
73f595c to
0fe277f
Compare
Collaborator
|
Can you please have a look at: Thanks! |
0fe277f to
e5f50bb
Compare
Contributor
Author
|
it was unsaved :( haha, thanks for the checking. |
458443f to
563cc59
Compare
Contributor
Author
|
@igaw I modified the names, and masking order as you recommended :) |
flbas Bits 6:5 indicate the most significant 2 bits of the Format Index of the supported LBA Format indicated in this data structure that was used to format the namespace Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Collaborator
|
Thanks! |
Collaborator
|
@sc108-lee, could send a fix/update for nvme-cli as well? |
Collaborator
|
Never mind, found the PR for nvme-cli. It just needs a refresh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flbas Bits 6:5 indicate the most significant 2 bits of
the Format Index of the supported LBA Format indicated
in this data structure that was used to format the namespace