Move 'host_traddr' and 'host_iface' into fabrics configuration#172
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jan 13, 2022
Merged
Move 'host_traddr' and 'host_iface' into fabrics configuration#172igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
Having 'host_traddr' and 'host_iface' as part of the controller structure is technically correct, but won't work for 'connect-all'. There we evaluate the contents of the discovery log page, and create new controllers based on that information. But as 'host_traddr' and 'host_iface' are Linux-only constructs, the spec (and the discovery log page) doesn't know about them, and can't provide us with that information. Signed-off-by: Hannes Reinecke <hare@suse.de>
Collaborator
|
Fixes linux-nvme/nvme-cli#1311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having 'host_traddr' and 'host_iface' as part of the controller
structure is technically correct, but won't work for 'connect-all'.
There we evaluate the contents of the discovery log page, and create
new controllers based on that information.
But as 'host_traddr' and 'host_iface' are Linux-only constructs, the
spec (and the discovery log page) doesn't know about them, and can't
provide us with that information.
Signed-off-by: Hannes Reinecke hare@suse.de