log: Introduce libnvme error codes#173
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jan 14, 2022
Merged
Conversation
hreinecke
requested changes
Jan 14, 2022
Add libnvme specific error codes which map to a specific error message. The system error codes in errno are too overloaded to figure out what is going wrong. With this we can remove the nvme_log_message buffer. This avoids having a global library buffer. Signed-off-by: Daniel Wagner <dwagner@suse.de>
hreinecke
approved these changes
Jan 14, 2022
| if (ret) | ||
| return ret; | ||
| if (ret) { | ||
| errno = -ret; |
Collaborator
There was a problem hiding this comment.
Aren't the error numbers positive?
Collaborator
There was a problem hiding this comment.
Ah, screw that. I misread the code.
Collaborator
|
So, this looks good. Should be ready to merge. Reviewed-by: Hannes Reinecke <hare@suse.de. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add libnvme specific error codes which map to a specific error
message. The system error codes in errno are too overloaded to figure
out what is going wrong.
With this we can remove the nvme_log_message buffer. This avoids
having a global library buffer.
Signed-off-by: Daniel Wagner dwagner@suse.de
Fixes: #160