Merged
Conversation
91ac9d2 to
1bc6ccd
Compare
The prefix of __nvme_get_log_page() is confusing as it usually indicates this is a private function. Rename this function to nvme_get_log_page(). The already existing one nvme_get_log_page() is renamed to nvme_get_log_page_padded() which is asking for 4k transfers. Signed-off-by: Daniel Wagner <dwagner@suse.de>
nvme-cli was using the library infrastructure for logging. In the meantime this has been removed, hence we can remove this function from the export map. Furthermore, move nvme_msg() and __nvme_msg() to private header. Signed-off-by: Daniel Wagner <dwagner@suse.de>
1bc6ccd to
6e268f5
Compare
Collaborator
Author
|
Rebased on the current master branch. |
igaw
commented
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups which can go on top of PR #202