Skip to content

Rename nvme get log page#207

Merged
igaw merged 2 commits intolinux-nvme:masterfrom
igaw:rename-__nvme_get_log_page
Feb 1, 2022
Merged

Rename nvme get log page#207
igaw merged 2 commits intolinux-nvme:masterfrom
igaw:rename-__nvme_get_log_page

Conversation

@igaw
Copy link
Copy Markdown
Collaborator

@igaw igaw commented Jan 31, 2022

Some cleanups which can go on top of PR #202

The prefix of __nvme_get_log_page() is confusing as it usually
indicates this is a private function. Rename this function to
nvme_get_log_page().

The already existing one nvme_get_log_page() is renamed to
nvme_get_log_page_padded() which is asking for 4k transfers.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
nvme-cli was using the library infrastructure for logging. In the
meantime this has been removed, hence we can remove this function from
the export map.

Furthermore, move nvme_msg() and __nvme_msg() to private header.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
@igaw igaw force-pushed the rename-__nvme_get_log_page branch from 1bc6ccd to 6e268f5 Compare February 1, 2022 10:26
@igaw
Copy link
Copy Markdown
Collaborator Author

igaw commented Feb 1, 2022

Rebased on the current master branch.

Comment thread src/nvme/linux.h
@igaw igaw merged commit e721ae3 into linux-nvme:master Feb 1, 2022
@igaw igaw deleted the rename-__nvme_get_log_page branch February 1, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants