ioctl: nvme_io_args.dspec(Directive Specific) value is 16 bits#230
ioctl: nvme_io_args.dspec(Directive Specific) value is 16 bits#230igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
There was a problem hiding this comment.
Can you move the dspec before dsm so that we have all __u16 grouped together. This avoids holes in the data structures.
There was a problem hiding this comment.
You need also to update all inline function in the header which use struct nvme_io_args. Older compilers are complaining if the order of the struct initialization are not strictly following the order of the deceleration.
sc108-lee
force-pushed
the
fix/io_cmd
branch
from
342bdab to
60df809
Compare
There was a problem hiding this comment.
You need also to update all inline function in the header which use struct nvme_io_args. Older compilers are complaining if the order of the struct initialization are not strictly following the order of the deceleration.
There was a problem hiding this comment.
BTW, could you drop the generated documentation update in this patch? This makes backporting unnecessary complex. And the plan is to update the generated documentation right before each release.
There was a problem hiding this comment.
Thanks for letting me know, I will remove doc updates :)
sc108-lee
force-pushed
the
fix/io_cmd
branch
from
60df809 to
a849f97
Compare
Command Dword 13 [31:16] Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
|
@igaw there is no direct use of this struct in inline function |
|
Right you are! :) |
2 participants
Command Dword 13 [31:16]
Signed-off-by: Steven Seungcheol Lee sc108.lee@samsung.com