dist: add missing BuildRequires to spec file#289
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 14, 2022
Merged
Conversation
According to https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/ Fixes linux-nvme#288 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Contributor
Author
|
@igaw how do you usually build RPM with meson ? I do it probably the wrong way like this: any better way ? |
Collaborator
|
As far I can tell, most distro do no use upstream spec files, instead they have their own which usually is embedded into a build system. The spec file provided here is thought as quick way for a developer to build a rpm and then distribute to the testers. So I can't really say if you are doing it wrong as I am using the build service from openSUSE. But looking at your snipped, I think this could be added to the Makefile as special target if meson doesn't really provide anything in this regard. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/
Fixes #288
Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com