Skip to content

test: print test logs for pass case#308

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
Arunpandian15:tests_23_03
Mar 25, 2022
Merged

test: print test logs for pass case#308
igaw merged 1 commit intolinux-nvme:masterfrom
Arunpandian15:tests_23_03

Conversation

@Arunpandian15
Copy link
Copy Markdown
Contributor

test log print for passed cases and aligning
log output.

Signed-off-by: Arunpandian J apj.arun@samsung.com

@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Mar 24, 2022

passed vs Passed:

test.c:         printf("Identify controller for:%s passed\n", nvme_ctrl_get_name(c));
test.c:         printf("smart log for:%s passed\n", nvme_ctrl_get_name(c));
test.c:         printf("  Allocated NS List Passed\n");
test.c:         printf("  Active NS List Passed\n");
test.c:         printf("  Ctrl List Passed\n");
test.c:         printf("  NSID Ctrl List Passed\n");
test.c:         printf("  Identify Primary Passed\n");
test.c:         printf("  Identify Secondary Passed\n");
test.c:         printf("  Identify NS granularity Passed\n");
test.c:         printf("  Identify UUID List Passed\n");

And given that 'ERROR' is all caps, shouldn't it be PASSED too?

While at it the "ERROR:" is prefixed, while 'Passed' is postfixed. This is also inconsistent.

test log print for passed cases and aligning
log output.

Signed-off-by: Arunpandian J <apj.arun@samsung.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@8d05597). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #308   +/-   ##
========================================
  Coverage          ?   4.30%           
========================================
  Files             ?      22           
  Lines             ?    3483           
  Branches          ?     754           
========================================
  Hits              ?     150           
  Misses            ?    3248           
  Partials          ?      85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d05597...c715277. Read the comment docs.

@Arunpandian15
Copy link
Copy Markdown
Contributor Author

Included PASSED as prefix for pass cases. Thanks @igaw

@igaw igaw merged commit 3e52d38 into linux-nvme:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants