fabrics: Avoid out of bounds string chomping#310
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 24, 2022
Merged
Conversation
Update all callsides of nvme_chomp to use the correct max lenght of the string to avoid out of bounds access. While at it, nvme_chomp() is used by fabrics.c to sanitize the traddr and trsvcid. There is no user outside of fabrics and clearly this is a small helper function. Thus move it to fabrics and rename it to a more comon name strchomp. Signed-off-by: Daniel Wagner <dwagner@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all callsides of nvme_chomp to use the correct max lenght of
the string to avoid out of bounds access.
While at it, nvme_chomp() is used by fabrics.c to sanitize the traddr
and trsvcid. There is no user outside of fabrics and clearly this is a
small helper function. Thus move it to fabrics and rename it to a more
comon name strchomp.
Signed-off-by: Daniel Wagner dwagner@suse.de
Fixes: #305