Merged
Conversation
Add two more arguments (nvme_ctrl_t and nvme_ns_t) to the nvme scan filter to allow the implementation to distinguish between the call sites. This allows for a more targeted approach when implementing filters. Signed-off-by: Hannes Reinecke <hare@suse.de>
As the scan filter accepts a namespace as argument use it to filter out namespaces, too. Signed-off-by: Hannes Reinecke <hare@suse.de>
For some reason the namespace path iterators have not been implemented. Signed-off-by: Hannes Reinecke <hare@suse.de>
This function was a hack to begin with, and as we now have namespace filters it can be removed. Signed-off-by: Hannes Reinecke <hare@suse.de>
Increase usability by adding an 'f_args' argument to pass user data to the filter function. Signed-off-by: Hannes Reinecke <hare@suse.de>
Collaborator
Author
|
@igaw is that what you had in mind? |
Collaborator
|
Yeah, this is way more generic and allows the user of the API to hold context without heaving to fallback using global variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update nvme_scan_filter_t to accept 4 arguments (subsystem, controller, namespace, f_args) and apply the filter for subsystem namespaces, too. This allows for a more targeted filter implementations and to remove the hack to display the ANA state.