fabrics: Lower log level in __nvmf_add_ctrl#351
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Apr 14, 2022
Merged
Conversation
9df8676 ("Add logging functionality to libnvme") introduced the logging. The log level for writing to /dev/nvme-fabrics was set on NOTICE because the kernel reports also status information such EALREADY which is a soft error. 866c288 ("fabrics: update log level for write failures") increased the log level without taking this into account. Drop back to NOTICE level to avoid error message when doing $ nvme connect-all .... Failed to write to /dev/nvme-fabrics: Operation already in progress Signed-off-by: Daniel Wagner <dwagner@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9df8676 ("Add logging functionality to libnvme") introduced the
logging. The log level for writing to /dev/nvme-fabrics was set on
NOTICE because the kernel reports also status information such
EALREADY which is a soft error.
866c288 ("fabrics: update log level for write failures")
increased the log level without taking this into account.
Drop back to NOTICE level to avoid error message when doing
$ nvme connect-all ....
Failed to write to /dev/nvme-fabrics: Operation already in progress
Signed-off-by: Daniel Wagner dwagner@suse.de
See: linux-nvme/nvme-cli#1505