Merged
Conversation
Coverity reported several issues. Signed-off-by: Hannes Reinecke <hare@suse.de>
Coverity reported a possible out-of-bounds access in inet6_pton and we never checked the return value of nvme_ctrl_identify() in nvme_fetch_cntrltype_dctype_from_id(), leading to a possible NULL pointer access in nvmf_is_registration_supported(). Signed-off-by: Hannes Reinecke <hare@suse.de>
Coverity found some resource leaks and a possible out-of-bounds access in nvme_ctrl_lookup_subsystem_name() where we could overflow the 'path' variable. Signed-off-by: Hannes Reinecke <hare@suse.de>
Coverity found some resource leaks. Signed-off-by: Hannes Reinecke <hare@suse.de>
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=========================================
- Coverage 3.77% 3.76% -0.01%
=========================================
Files 23 23
Lines 3553 3561 +8
Branches 687 688 +1
=========================================
Hits 134 134
- Misses 3348 3356 +8
Partials 71 71
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of coverity fixes; with that libnvme is now officially bug-free (tm) as far as coverity is concerned.