types.h: add missing fields for identify controller DS#370
types.h: add missing fields for identify controller DS#370igaw merged 6 commits intolinux-nvme:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
======================================
Coverage 3.67% 3.67%
======================================
Files 23 23
Lines 3645 3645
Branches 703 703
======================================
Hits 134 134
Misses 3440 3440
Partials 71 71
Continue to review full report at Codecov.
|
igaw
left a comment
igaw
left a comment
There was a problem hiding this comment.
Please split the changes and have a matching commit message. Thanks
There was a problem hiding this comment.
If I am not completely mistaken, this has nothing to do with DS, right? Could you split these changes into smaller commits which describe each changes.
There was a problem hiding this comment.
same here, the change is okay but it doesn't match the commit message.
Hi Daniel, Thanks for the review comments. |
1. Add enum and description for not reported power scale. 2. Add enum and description for power workload. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Add bit 10, command and feature lockdown capability enum and its description. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Add bit 5, support multiple update detection enum and its description. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
1. Add missing description for existing log page attributes. 2. Add bit 5, 6 enum and their respective descriptions. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Add bit 8, NVM command set copy command support enum and its description. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Add bit3, format NVM command support nsid value set to FFFFFFFFh enum and its description. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
|
Excellent! Thanks for the nice series. This is way simpler to review it too! |
3 participants
Various fields and their description are missing from identify controller data structure. This patch includes all those.