MI: Update MI Admin API to suit core#386
Merged
igaw merged 3 commits intolinux-nvme:masterfrom Jun 17, 2022
Merged
Conversation
This change establishes a new (internal) header, api-types.h, and moves the existing _args structs from ioctl.h. This will allow us to share the definitions between the direct-ioctl and MI interfaces. The changes are purely a move of the struct definitions, and some whitespace fixes, and some new file-level comments. None of the structs are altered. Fixes linux-nvme#373 . Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
…mands This change adds a --partial argument to the mi-mctp command, so we have an example of both the full and partial identify APIs. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Collaborator
|
Nice cleanup. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset unifies the first set of MI Admin commands to use the
_args-struct-style API, and updates the example code inmi-mctpto suit, and clarify the usage of theidentify_partialfunction.This is dependent on #384 to expose those
_argstypes.As always, let me know if you have any queries/comments!