types: fix typo on nvme_mi_ccs definitions in public API#413
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jul 4, 2022
Merged
types: fix typo on nvme_mi_ccs definitions in public API#413igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
The NVMe-MI spec defines the Composite Controller Status definitions using the abbreviation CCS. However, the libnvme code (since initial commit) has used CSS, not CCS (except for CCS_RDY...). This change fixes the definitions to use the _CCS_ names, and adds a set of #defines to allow the old names to be used, including for the enum itself. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=======================================
Coverage 15.41% 15.41%
=======================================
Files 31 31
Lines 4866 4866
Branches 950 950
=======================================
Hits 750 750
Misses 3885 3885
Partials 231 231
Continue to review full report at Codecov.
|
Collaborator
Author
|
There may be implications when changing these, particularly with the public API. I'm happy to rework this if necessary, or can just use the old names in my upcoming changes. |
Collaborator
|
I think those defines should take care with the backwards compatibility. At least I can't see any problems with it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NVMe-MI spec defines the Composite Controller Status definitions
using the abbreviation CCS. However, the libnvme code (since initial
commit) has used CSS, not CCS (except for CCS_RDY...).
This change fixes the definitions to use the CCS names, and adds a set
of #defines to allow the old names to be used, including for the enum
itself.
Signed-off-by: Jeremy Kerr jk@codeconstruct.com.au