fabrics: add NCC to nvmf_disc_eflags#421
Conversation
TP8010 defines an additional EFLAG: No CDC Connectivity (NCC) Signed-off-by: Martin Belanger <martin.belanger@dell.com>
| [NVMF_DISC_EFLAGS_DUPRETINFO | | ||
| NVMF_DISC_EFLAGS_NCC] = "duplicate discovery information, " | ||
| "no cdc connectivity", | ||
| [NVMF_DISC_EFLAGS_EPCSD | |
There was a problem hiding this comment.
I wonder if we should introduce a variant of arg_str which is able to handle non exclusive flags?
There was a problem hiding this comment.
Wouldn't that function need to dynamically allocate memory for the string? The problem with that is that users would need to free it. Unless we require users to pass a pre-allocated buffer and make it their responsibility to allocated the right amount of memory.
There was a problem hiding this comment.
Yep, you are right. I just didn't like the repetition of the strings. Because the interface is fix, we can't change this anyway.
| [NVMF_DISC_EFLAGS_DUPRETINFO | | ||
| NVMF_DISC_EFLAGS_NCC] = "duplicate discovery information, " | ||
| "no cdc connectivity", | ||
| [NVMF_DISC_EFLAGS_EPCSD | |
There was a problem hiding this comment.
Yep, you are right. I just didn't like the repetition of the strings. Because the interface is fix, we can't change this anyway.
2 participants
TP8010 defines an additional EFLAG: No CDC Connectivity (NCC)
Signed-off-by: Martin Belanger martin.belanger@dell.com