ioctl: Honor rae in nvme_get_nsid_log#440
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jul 25, 2022
Merged
Conversation
The nvme_get_nsid_log() helper has a rae (Retain Asynchronous Events) parameter, but we currently ignore this when constructing the Get Log Page command arguments. This is a behavior change and not an API change. But the good thing is only for newly build binaries because all helpers are static inline fuctions. Reported-by: Reported-by: Jeremy Kerr <jk@codeconstruct.com.au> Signed-off-by: Daniel Wagner <dwagner@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nvme_get_nsid_log() helper has a rae (Retain Asynchronous Events)
parameter, but we currently ignore this when constructing the Get Log
Page command arguments.
This is a behavior change and not an API change. But the good thing is
only for newly build binaries because all helpers are static inline
fuctions.
Reported-by: Reported-by: Jeremy Kerr jk@codeconstruct.com.au
Signed-off-by: Daniel Wagner dwagner@suse.de
Fixes: #437
BTW, I've decided against updating
test/test.c, as I am not sure if thiswas intended setting or just set without a lot of thinking.