build: Update min version of meson to 0.48#511
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Oct 28, 2022
Merged
Conversation
python3.extension_module() is depending on gnu_symbol_visibility. So arguably, this has been from day 0. Version 0.47 was released on Jul 02, 2018 and 0.48 on Sep 22, 2018. Even Debian oldstable ships 0.49. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Contributor
|
While it's perfectly fine to bump the minimum version of Meson, you are not actually setting this kwarg. Meson's python module does this internally, via mesonbuild/meson#10369 The warning is actually bogus, but it's emitted in the backend not in the interpreter, so we do not actually know whether it was set by the python module or by the user's meson.build. Fun! Also way too annoying to fix, it will just fix itself as part of the pending rewrite in mesonbuild/meson#10714. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python3.extension_module() is depending on gnu_symbol_visibility. So arguably, this has been from day 0.
Version 0.47 was released on Jul 02, 2018 and 0.48 on Sep 22,
2018. Even Debian oldstable ships 0.49.
Signed-off-by: Daniel Wagner dwagner@suse.de
Fixes: #496