fabris: Use doublicate string when merging configs#512
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Oct 28, 2022
Merged
fabris: Use doublicate string when merging configs#512igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
We have to use strdup here, because the merged config will be freeing these pointers eventually. Without it, we are going to double free it. Signed-off-by: Daniel Wagner <dwagner@suse.de>
igaw
force-pushed
the
fix-merge-config
branch
from
7885cf4 to
d187b21
Compare
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 24.35% 24.35%
=======================================
Files 32 32
Lines 6012 6012
Branches 1247 1247
=======================================
Hits 1464 1464
Misses 4052 4052
Partials 496 496
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to use strdup here, because the merged config will be freeing these pointers eventually. Without it, we are going to double free it.
Signed-off-by: Daniel Wagner dwagner@suse.de
Fixes: linux-nvme/nvme-cli#1707