Skip to content

fabrics: Fix bad UUID size introduced in recent UUID changes#538

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
martin-belanger:fix-uuid-size
Nov 21, 2022
Merged

fabrics: Fix bad UUID size introduced in recent UUID changes#538
igaw merged 1 commit intolinux-nvme:masterfrom
martin-belanger:fix-uuid-size

Conversation

@martin-belanger
Copy link
Copy Markdown
Contributor

Fixes: #537

Signed-off-by: Martin Belanger martin.belanger@dell.com

@martin-belanger
Copy link
Copy Markdown
Contributor Author

@igaw - I don't know why, but some of the checks are failing to build subproject/openssl.

That has nothing to do with the one line change I made.

@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Nov 21, 2022

@igaw - I don't know why, but some of the checks are failing to build subproject/openssl.

That has nothing to do with the one line change I made.

The static builds will build the OpenSSL library which produces warnings (new?). With -werror set this breaks the build. We have to remove the compile flag for the static builds.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #538 (ff17444) into master (0a5c066) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   24.58%   24.31%   -0.28%     
==========================================
  Files          32       32              
  Lines        6137     6133       -4     
  Branches     1290     1278      -12     
==========================================
- Hits         1509     1491      -18     
- Misses       4115     4128      +13     
- Partials      513      514       +1     
Impacted Files Coverage Δ
src/nvme/fabrics.c 4.60% <ø> (+<0.01%) ⬆️
src/nvme/mi.h 70.73% <0.00%> (-1.37%) ⬇️
test/mi.c 64.68% <0.00%> (-0.87%) ⬇️
ccan/ccan/list/list.h 90.00% <0.00%> (-0.48%) ⬇️
src/nvme/mi.c 57.01% <0.00%> (-0.13%) ⬇️
src/nvme/tree.c 8.63% <0.00%> (-0.05%) ⬇️
src/nvme/ioctl.c 0.00% <0.00%> (ø)
src/nvme/ioctl.h 0.00% <0.00%> (ø)
src/nvme/linux.c 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

71c25d1 ("util: Add simple UUID type") introduced a regression in
nvmf_get_tel(). nvmf_get_tel() returns the lenght of the binary
representation. Hence use NVME_UUID_LEN instead.

Signed-off-by: Martin Belanger <martin.belanger@dell.com>
[dwagner: massaged commit message]
Signed-off-by: Daniel Wagner <dwagner@suse.de>
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Nov 21, 2022

Rebased the commit on the current master with a build config change so that we can test if the builds are fixed now. While at also replaced the github reference in the commit message. The reason for this is that I want to avoid to have git commit message depending on an external service. We never know when we have to move the repo.

@igaw igaw merged commit 826d023 into linux-nvme:master Nov 21, 2022
@martin-belanger martin-belanger deleted the fix-uuid-size branch March 1, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad UUID size in nvmf_get_tel()

3 participants