Skip to content

tree: Fix leaking struct nvme_ns.generic_name#548

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
tbzatek:valgrind-fixes-2
Nov 30, 2022
Merged

tree: Fix leaking struct nvme_ns.generic_name#548
igaw merged 1 commit intolinux-nvme:masterfrom
tbzatek:valgrind-fixes-2

Conversation

@tbzatek
Copy link
Copy Markdown
Contributor

@tbzatek tbzatek commented Nov 30, 2022

==306445== 96 bytes in 16 blocks are definitely lost in loss record 3,171 of 3,553
==306445==    at 0x484386F: malloc (vg_replace_malloc.c:393)
==306445==    by 0x4FA2F6D: strdup (strdup.c:42)
==306445==    by 0x7B9C477: nvme_ns_set_generic_name (tree.c:1802)
==306445==    by 0x7B9C51B: nvme_ns_open (tree.c:1820)
==306445==    by 0x7B9C606: __nvme_scan_namespace (tree.c:1853)
==306445==    by 0x7B9CA0C: nvme_subsystem_scan_namespace (tree.c:1931)
==306445==    by 0x7B98C81: nvme_subsystem_scan_namespaces (tree.c:496)
==306445==    by 0x7B991BC: nvme_scan_subsystem (tree.c:597)
==306445==    by 0x7B97DA1: nvme_scan_topology (tree.c:118)
==306445==    by 0x7B97FA9: nvme_scan (tree.c:177)

==306445== 96 bytes in 16 blocks are definitely lost in loss record 3,171 of 3,553
==306445==    at 0x484386F: malloc (vg_replace_malloc.c:393)
==306445==    by 0x4FA2F6D: strdup (strdup.c:42)
==306445==    by 0x7B9C477: nvme_ns_set_generic_name (tree.c:1802)
==306445==    by 0x7B9C51B: nvme_ns_open (tree.c:1820)
==306445==    by 0x7B9C606: __nvme_scan_namespace (tree.c:1853)
==306445==    by 0x7B9CA0C: nvme_subsystem_scan_namespace (tree.c:1931)
==306445==    by 0x7B98C81: nvme_subsystem_scan_namespaces (tree.c:496)
==306445==    by 0x7B991BC: nvme_scan_subsystem (tree.c:597)
==306445==    by 0x7B97DA1: nvme_scan_topology (tree.c:118)
==306445==    by 0x7B97FA9: nvme_scan (tree.c:177)
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #548 (9eaeb31) into master (403e843) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
- Coverage   24.30%   24.30%   -0.01%     
==========================================
  Files          32       32              
  Lines        6134     6135       +1     
  Branches     1278     1278              
==========================================
  Hits         1491     1491              
- Misses       4129     4130       +1     
  Partials      514      514              
Impacted Files Coverage Δ
src/nvme/tree.c 8.62% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@igaw igaw merged commit 5f2d222 into linux-nvme:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants