test: mi: ensure we're providing full initialised buffers to the libnvme-mi API#565
Merged
igaw merged 2 commits intolinux-nvme:masterfrom Jan 26, 2023
Merged
test: mi: ensure we're providing full initialised buffers to the libnvme-mi API#565igaw merged 2 commits intolinux-nvme:masterfrom
igaw merged 2 commits intolinux-nvme:masterfrom
Conversation
We have a few places where we're passing an uninitialised pointer argument to the libnvme API in the MI tests. Add an explicit zero init for these. Fixes: linux-nvme#563 Reported-by: Daniel Wagner <dwagner@suse.de> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
We're issuing an admin command with up to four bytes of data in the request. Although these will all fail due to invalid args, we still want to provide enough data to simulate the full request. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Closed
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a couple of cases in the MI test code where we're either not providing an initialised argument buffer, or a request with no data allocation.
These changes fix those cases, so we're a closer match to actual API usage, and avoid issues (like #563) from uninit arg data.