Make unique discovery controllers persistent as default#1765
Merged
igaw merged 4 commits intolinux-nvme:masterfrom Jan 24, 2023
Merged
Make unique discovery controllers persistent as default#1765igaw merged 4 commits intolinux-nvme:masterfrom
igaw merged 4 commits intolinux-nvme:masterfrom
Conversation
igaw
force-pushed
the
make-pdc-default
branch
from
d12e496 to
d487dee
Compare
igaw
force-pushed
the
make-pdc-default
branch
3 times, most recently
from
2ac2ce4 to
bc074af
Compare
Update libnvme wrap to include the unique discovery controller API changes. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Currently, the well known discovery controller is used per default even though the target might support unique discovery controller as defined in TP8013. Change the default behavior to use the unique discovery controller whenever the target supports it. Signed-off-by: Daniel Wagner <dwagner@suse.de>
igaw
force-pushed
the
make-pdc-default
branch
from
bc074af to
467028c
Compare
igaw
changed the title
igaw
changed the title
igaw
force-pushed
the
make-pdc-default
branch
from
467028c to
3c5b6e4
Compare
The TP8014 adds two new flags for providing information to the host which discovery controller is returning the same information we already know or if the discovery controller doesn't support explicit persistency. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Do not disconnect unique discovery controller on default. Signed-off-by: Daniel Wagner <dwagner@suse.de>
igaw
force-pushed
the
make-pdc-default
branch
from
3c5b6e4 to
1959d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implemention changes the default behavior considerable:
The first two are backwards compatible, that means if the user isn't really using '--persistent' as command line option, the outcome should be the same. The last change is a bit daunting IMO. Is this really what the TP8013 mandates?
Fixes #1670