use simpler, less error-prone option parsing; update man pages & add man page for smart-log-add#26
Closed
kaoudis wants to merge 3 commits intolinux-nvme:masterfrom
Closed
use simpler, less error-prone option parsing; update man pages & add man page for smart-log-add#26kaoudis wants to merge 3 commits intolinux-nvme:masterfrom
kaoudis wants to merge 3 commits intolinux-nvme:masterfrom
Conversation
added 2 commits
August 12, 2015 15:53
…nd less need for documentation maintenance
Contributor
|
This fell off my radar ... I think we should stick with the parser we're using, but it'd certainly be nice if it was simpler to setup. Lots of structures to define with rigid relations among structures, and duplicating entries for short and long opts is a bit annoying. Macro magic will help. |
jimmunn
pushed a commit
to Micron-TPG-OSS/nvme-cli
that referenced
this pull request
Feb 23, 2026
* add tests kdoc and uuid * Update libnvme/scripts/kernel-doc-check.ps1 no perl found error message Co-authored-by: Broc Going <bgoing@micron.com> --------- Co-authored-by: Broc Going <bgoing@micron.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argconfig was simultaneously more powerful and more bug-prone, even after some intense bug chasing, than needed for nvme sub-commands currently part of the application. Therefore, simply use getopt_long_only (since this was the only part of the argconfig_parse function code we were really using, anyway).
Add a small 'help' function to replace the used parts of the argconfig_print_help function. Put the rest of the help information into the man pages, update all man pages and add one for smart-log-add (which didn't have a manpage yet).
Also, update zsh tab completion strings (completions/_nvme) since they were slightly out of sync with the man pages.
Let me know if anything should be changed :)