src: order includes per common recommendation#3172
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 13, 2026
Merged
Conversation
Collaborator
Author
|
FWIW, there is also the recommendation to use the reverse ordering. Since this project started using the ordering as done in this patch, I'd say we go with this cleanup. If someone strongly objects we can still reorder them in reverse. I'd just like to get it consistent, which this patch does. |
Apply the commonly recommended include ordering across all files. 1. Standard/POSIX headers (alphabetical) 2. System headers with path prefix: sys/, arpa/, linux/, net/ (alphabetical) 3. Third-party library headers: ccan, dbus, json, keyutils, liburing, openssl (alphabetical) 4. Project public headers: libnvme.h, libnvme-mi.h, nvme/... 5. Local/private headers: "..." The changes was prepared by Copilot. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
header-mania-continues
branch
from
8c20c42 to
d854cb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the commonly recommended include ordering across all files.
The changes was prepared by Copilot.