libnvme: move accessor generator to tools/generator/#3189
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 17, 2026
Merged
libnvme: move accessor generator to tools/generator/#3189igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
The code generator (generate-accessors.c, update-accessors.sh, and supporting files) does not belong alongside the library source in src/nvme/. Move it to tools/generator/ to make clear it is developer tooling rather than library code. While at it: - Move accessors.ld from src/nvme/ to src/, alongside the other version scripts (libnvme.ld, libnvmf.ld). src/meson.build now picks it up directly via meson.current_source_dir(), so no cross-directory variable passing is needed. - Eliminate src/nvme/meson.build; its generator build rules move to tools/generator/meson.build. - Add a banner to the generated accessors.ld (SPDX, copyright, ASCII logo, and regeneration instructions) matching the banners already present in accessors.c and accessors.h. The generated files (accessors.c, accessors.h) remain in src/nvme/ where the compiler expects them. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code generator (generate-accessors.c, update-accessors.sh, and supporting files) does not belong alongside the library source in src/nvme/. Move it to tools/generator/ to make clear it is developer tooling rather than library code.
While at it:
The generated files (accessors.c, accessors.h) remain in src/nvme/ where the compiler expects them.