Merged
Conversation
igaw
reviewed
Mar 30, 2026
|
|
||
| static void nvme_show_cmd_err(const char *msg, bool admin, | ||
| struct nvme_passthru_cmd *cmd, int err) | ||
| static void nvme_show_cmd_err(const char *msg, bool admin, __u8 *opcode, |
Collaborator
There was a problem hiding this comment.
I suggest to use pass by value here: __u8 opcode.
Contributor
Author
There was a problem hiding this comment.
Just fixed as suggested.
igaw
reviewed
Mar 30, 2026
|
|
||
| return NULL; | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
Would you mind to add the other command specific status values here as well while at it? Thanks
Contributor
Author
There was a problem hiding this comment.
Also added the other command specific status values. Thank you.
Since previously always use false without the admin value. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since only cmd parameter opcode value used by the print function. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since the status code is duplicated with the fw-download status code. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
feature-overlap-range
branch
from
7da1df8 to
e848bfc
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.