fix: remove unneeded windows check#3214
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Mar 30, 2026
Merged
Conversation
a1c4970 to
40d256a
Compare
Collaborator
|
Okay, sounds reasonable. Please add some rational to the commit message. We never know for how long a forge is usable, so we might have to move at some point. Thus commit message should carry the important information. It's obviously nice to have something on github but the git history is really important. |
ead2d3f to
c01ebbb
Compare
Upon further investigation this Windows check is no longer needed now that we are using the MSYS2 environment. The code used to check whether netdb is supported, `have_netdb`, compiles on MSYS2 and does not produce errors during build configuration. Signed-off-by: Brandon Capener <bcapener@micron.com>
c01ebbb to
29c934e
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code we had in our PR #3129
before the changes got merged the code was changed in the PR #3213 to...
Looking closer at it, we don't need to check for windows now that we are using the MSYS2 environment.