min: Cleaned up usage of MIN in favor of safer CCAN min.#3272
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Apr 15, 2026
Merged
min: Cleaned up usage of MIN in favor of safer CCAN min.#3272igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
Libnvme's util.c uses a combination of CCAN's min from minmax.h and the MIN defined in param.h. The CCAN implementation has typechecking and is more portable, whereas the param.h definition of MIN only exists on Linux. - Updating util.c to use CCAN's min implementation consistently. - Removing unused MIN definition in nbft.c. Signed-off-by: Broc Going <bgoing@micron.com>
Collaborator
|
This looks good. Are you resubmitting it? |
Contributor
Author
|
Collaborator
|
Yes, sorry busy moving stuff around. Whenever I pull on a string I end up a big refactoring excersice. Anyway, the code base gets better. I check what is missing after the libnvme_fabrics_config refactoring. What needs to go from the public API. Hopefully this was the last big piece. Obviously, there is still a bit to do in the c files. The main goal is to get the public API done first. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libnvme's util.c uses a combination of CCAN's min from minmax.h and the MIN defined in param.h. The CCAN implementation has typechecking and is more portable, whereas the param.h definition of MIN only exists on Linux.