Merged
Conversation
Collaborator
Author
|
@tbzatek can you have a look at this? |
Contributor
|
FYI: I've added TODO for myself to sync |
To follow the existing pattern, move the NVMe specification types into a separate header. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Follow the existing pattern to different prefixes for the NVMe spec types and the library API. Thus for nbft, use libnbft_ as prefix. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Collaborator
Author
|
FWIW, the current spec is at 1.3 but I don't know what has changed. |
Contributor
I'm involved in the work group, but never took the time to sync the changes. Not much has changed really, mostly wording and perhaps some extra flags. The nvme-cli connection code doesn't respect many of the flags anyway as actual firmware implementations do not support everything either, having no reference firmware implementation to test the code against. I'll have a look anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the NVMe spec part from the library types and rename them. Follow the pattern, thus use
libnbft_as prefix.