libnvme: validate context in libnvme_rescan_ctrl()#3510
Merged
igaw merged 1 commit intoJun 26, 2026
Conversation
libnvme_rescan_ctrl() derives the global context from the controller. The derived @ctx is then passed to libnvme_ctrl_scan_namespaces() and libnvme_ctrl_scan_paths(), both of which expect a valid context. Instead of adding NULL checks in each callee, validate @ctx in libnvme_rescan_ctrl() and return early if no valid context is available. This avoids propagating an invalid context to the namespace and path scan helpers. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnvme_rescan_ctrl() derives the global context from the controller. The derived @ctx is then passed to libnvme_ctrl_scan_namespaces() and libnvme_ctrl_scan_paths(), both of which expect a valid context.
Instead of adding NULL checks in each callee, validate @ctx in libnvme_rescan_ctrl() and return early if no valid context is available.
This avoids propagating an invalid context to the namespace and path scan helpers.