nvme: Open files using nvme_open_rawdata to fix Windows issues#3527
Merged
igaw merged 1 commit intoJul 1, 2026
Merged
Conversation
Reading files that may have raw binary data on Windows without using the O_BINARY flag when opening can cause some bytes to be misinterpreted or mishandled. This can lead to bad data or truncated reads. Use nvme_open_rawdata to ensure that O_BINARY is added if supported. Fixes firmware file reading issues found during testing on Windows, as well as other potential issues on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading files that may have raw binary data on Windows without using the O_BINARY flag when opening can cause some bytes to be misinterpreted or mishandled. This can lead to bad data or truncated reads. Use nvme_open_rawdata to ensure that O_BINARY is added if supported.
Fixes firmware file reading issues found during testing on Windows, as well as other potential issues on Windows.